Skip to content

fix: propagate variant to notification messages #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tarquinen merged 8 commits into from
Jan 6, 2026
Merged

fix: propagate variant to notification messages #225

Tarquinen merged 8 commits into from
Jan 6, 2026

Conversation

@cau1k
Copy link
Contributor

@cau1k cau1k commented Jan 6, 2026 •
edited
Loading

less messy than prev pr but this impl:

  • stores the latest variant in state.variant (no longer loops over every message)
  • pins opencode-ai/sdk so we can make use of v2 UserMessage that includes the variant type

@cau1k cau1k changed the title fix: finds and adds missing variant in synthetic messages fix: propagate variant to notification messages Jan 6, 2026
@cau1k cau1k marked this pull request as ready for review January 6, 2026 16:37
Tarquinen
Tarquinen reviewed Jan 6, 2026
View reviewed changes
@Tarquinen Tarquinen merged commit 3267d9f into Opencode-DCP:dev Jan 6, 2026
1 check passed
@cau1k cau1k mentioned this pull request Jan 7, 2026
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tarquinen Tarquinen Tarquinen left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cau1k @Tarquinen